testing-library-docs icon indicating copy to clipboard operation
testing-library-docs copied to clipboard

Remove contradiction from documentation

Open skonky opened this issue 1 year ago • 3 comments

I found something confusing in the documentation regarding testing-library-dom

Here you say that testing-library-dom should be resolved via the framework wrapper

And when you then go to the actual framework wrapper (in my case react) it states the following:

To get started with React Testing Library, you'll need to install it together with its peerDependency @testing-library/dom: npm install --save-dev @testing-library/react @testing-library/dom

but this contradicts what is said earlier right?

skonky avatar Sep 24 '24 14:09 skonky

Deploy Preview for testing-library ready!

Name Link
Latest commit fc3a68b2baca85956b009b6747906b9aef322f3f
Latest deploy log https://app.netlify.com/sites/testing-library/deploys/66f2cfb35a118c0008bd83be
Deploy Preview https://deploy-preview-1430--testing-library.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 24 '24 14:09 netlify[bot]

Hi @skonky, thanks for this. This is not true anymore for all of our framework wrappers. RTL for examples does not include DTL anymore. I believe that this should be fixed in user-event.

MatanBobi avatar Sep 24 '24 14:09 MatanBobi

@MatanBobi Cool, I will update the docs to say the opposite of what I did in the current commit :)

skonky avatar Sep 25 '24 12:09 skonky