Matan Borenkraout
Matan Borenkraout
Hi @sidrak19, thanks for opening this one. It doesn't look like this bug report has enough info for one of us to reproduce it. Please provide a CodeSandbox ([https://react.new/](https://react.new/)), or...
> @MatanBobi, would it make sense to upgrade RTL itself? Node.js v14 and v16 are [EOL](https://nodejs.org/en/download/releases). I think it's best RTL migrates to the LTS, which is v18, which is...
@kettanaito do you want me to put the old examples too? Since we're not yet enforcing Node 18, we should probably keep both examples there.
> @MatanBobi, I'm concerned that will be confusing for the reader. If RTL doesn't support Node.js 18 yet, leave the old examples but add a note that recommends using MSW...
> Because there are already some requests to update this I think we should merge this. We can add a warning on this page that MSW requires Node.js v18+. What...
Closing in favor of #1378. Thanks @kettanaito for working on this :)
AFAIU from the [code](https://github.com/testing-library/user-event/blob/main/package.json#L69), `@testing-library/dom` is still a peer dependency, doesn't that mean we still need that? I understand that if a user installs `@testing-library/react` for example they'll have it...
Since people don't really care about the warnings from the `npm i` script, maybe we can add a note about that for old users?
> A note about what? Can you give an example? That explicitly installing `@testing-library/dom` is still needed if you're using npm < 7. Since `user-event` doesn't have an engines definition...
> Our `engines` are out of date because Node 16 support was recently dropped, but I'll make sure this is fixed soon and users should have already upgraded Node for...