Manish Goregaokar comments

Results 1096 comments of


                                            Manish Goregaokar

trafficstars

Fix negative numbers across icu_calendar

I ended up fixing half of this whilst attempting to fix the coptic issue

Fix negative numbers across icu_calendar

Pretty sure that ` check(-1828, -5, 12, 31);` is incorrect; I just ran the original lisp code and it wants it to be 30. @sffc where did you get these...

Fix negative numbers across icu_calendar

Oh, though it might be a zero-indexed vs 1-indexed difference, argh

Fix negative numbers across icu_calendar

Nope, we're both 1-indexed.

Fix negative numbers across icu_calendar

Ah, there's your problem, fixed day 0 is not Jan 1 1 AD (that's fixed 1), it is Dec 31 1 BC I fixed it in the tests

Fix negative numbers across icu_calendar

https://github.com/unicode-org/icu4x/issues/2703 fixes _most_ of this, except for week_of. I didn't really add many tests though. I think we ought to fuzz pre-https://github.com/unicode-org/icu4x/issues/2703 code and include those testcases.

Fix negative numbers across icu_calendar

@atcupps should this issue be closed now, or are there still bits left to be handled?

Integer sizes of day_of_year, day_of_month

Probably, yes.

Don't copy large Arcs over IPC

Not entirely certain but https://doc.servo.org/ipc_channel/ipc/struct.IpcSharedMemory.html might be what I'm looking for

Don't copy large Arcs over IPC

Yeah, it seems like IPCSharedMemory is being used everywhere for this purpose. Not sure how to make it work with the weakptr stuff in the font cache task.