Manish Goregaokar comments

Results 1179 comments of


                                            Manish Goregaokar

Mismatch between ICU4X and ECMA402 for `package:intl4x`

@sffc you're the most up to date on ECMA402 coverage: do you know if we have issues for most of these? Are any of these unexpected (they seem to be...

Mismatch between ICU4X and ECMA402 for `package:intl4x`

RGSA, which is is also missing in ICU but ICU lies about it

Fix consistency of from_bytes, try_from_bytes, from_str, try_from_str

I roughly agree with Robert's stance with the caveat that I'm not a huge fan of having inherent methods named the same as trait methods that are implemented by the...

Fix consistency of from_bytes, try_from_bytes, from_str, try_from_str

> @Manishearth If you hold this position, should we reconsider #4590? It's a very weakly held position, I think #4590 is okay. I'm also fine with the proposal here for...

Fix consistency of from_bytes, try_from_bytes, from_str, try_from_str

@robertbastian How much of this is done? Does this just need a final audit, or are there pieces that still need doing?

Fix consistency of from_bytes, try_from_bytes, from_str, try_from_str

@robertbastian is that the only case? I'd say we can close this issue then.

Fix consistency of from_bytes, try_from_bytes, from_str, try_from_str

Assuming https://github.com/unicode-org/icu4x/pull/6103, I think we can close this out once that lands.

Fix consistency of from_bytes, try_from_bytes, from_str, try_from_str

That landed, nothing left is in stable code.

Rename `provider` modules to `provider_unstable` in 2.0, and DataMarker::Yokeable to DataMarker::DataStruct?

For UnstableSealed traits we should mark UnstableSealed and the methods of UnstableSealed traits (but not the assoc types) as `cfg(not(feature = unstable), doc(hidden))`

Reword "computationally heavy" language in docs

Assigning to @sffc since it's a part of the whole set of datetime changes