Manish Goregaokar

Results 1207 comments of Manish Goregaokar

https://github.com/unicode-org/icu4x/commit/0753b061cfc83ebe5454a9c0c457fd9dea895f47 @sffc what do you think of releasing icu_calendar 2.0.3 with that patch and then declaring this issue fixed?

@sffc Is it? For calendars with eras that PR makes extendedYear = temporalYear for all of them. temporal_rs just uses the extended year as arithmetic year. The only potential divergence...

> If ICU4X doesn't do that, it is a bug. Ah, I see. Seems like the divergence is just in ethiopic (and chinese/dangi where the concept works differently). Should we...

> AFAICT, the only way for `CollatorBorrowed::try_new` to fail is to override baked data with badly-generated baked data. No, you can give it bad options. https://github.com/unicode-org/icu4x/blob/6187c85412aa9154ac2d8e6f5310fa297ff0026b/components/collator/src/comparison.rs#L577-L594 I'm going to close...

But you are correct: we do not error for "incorrect baked data"; we have GIGO behavior. (we still try to not panic)

That's https://github.com/unicode-org/icu4x/issues/6633, we should close this as a duplicate then. There are two potential issues: Adding const constructible new_root (#6633), and making try_new infallible (this issue, which cannot be done)

Hmm, yeah, potentially? I'd start with an internal abstraction first, but yes, it would be cool to incubate this and see if it fits in the overall zerovec œuvre. The...

Marking as a non-blocker in the 2.0 dashboard. Unlikely to make 2.0