Manish Goregaokar

Results 1094 comments of Manish Goregaokar
trafficstars

When I discussed this issue with @roozbehp he had some examples of Persian words that do this, IIRC. Just to lay it out, there are multiple issues here, of varying...

I've filed browser bugs for some of the issues arising from this confusion in https://bugzilla.mozilla.org/show_bug.cgi?id=1680610 and https://bugs.chromium.org/p/chromium/issues/detail?id=1155268

@svgeesus correct, the issues I've filed on browsers deal with both: the underline positioning on some browsers on some OSes is really bad independently of skip-ink (which makes it worse)

I'm not sure! I upgraded rustc a couple versions in https://github.com/unicode-org/icu4x/pull/1783 and suddenly disk space usage for the feature task has more than doubled (I don't have the exact numbers...

You could use `cargo build -v --message-format=json` and delete selected binaries but it's fiddly and you also kinda want stuff to be cached.

yeah the thing is that all of that is doable, but chunking kinda lets you do much the same without as many nuances

_okay so_ there's actually a bug in `cargo-all-features` here wrt the new dependency stuff, `skip_optional_dependencies` isn't working

Yeah, `cargo metadata` unconditionally generates a `"foo": ["dep:foo"]` entry for each optional dependency. Gonna fixup the code here.

(is there a reason this crate isn't using serde-json and/or clap?)

https://github.com/frewsxcv/cargo-all-features/issues/29