Manish Goregaokar

Results 1094 comments of Manish Goregaokar
trafficstars

I mean, we're also happy to make changes on our end, if cargo-make can be updated to handle this and stuff it's also fine. Such CI tools are popular but...

@kinnison btw, mind changing this issue title to something like "new rustup version breaks with `error: no such subcommand: `+nightly-2022-04-05`" (unfortunately I don't have edit access to this repo anymore)

It occurs to me that for approximate suggestions we should spit them out _after_ we've fixed everything else, so that if the user makes manual changes it's nbd. We should...

It would print out a diff of what it _would_ change. with cargo check you still have to wonder about which suggestions would get applied, and how On Mon, Sep...

I think this library will also need support for doing all this without editing, no?

also cc @ehuss for thinking about what the UX would be like from cargo's perspective

also cc @ehuss for thinking about what the UX would be like from cargo's perspective

@estebank no, I don't think that'll help. MaybeIncorrect already _is_ that variant: there's another one for when you're absolutely sure it's incorrect. MaybeIncorrect is just when it's a bad idea...

The problem is that MaybeIncorrect is often not stuff that is incorrect because it won't compile, it's incorrect because it changed the semantics of the program in a way clippy...