Manish Goregaokar

Results 1159 comments of Manish Goregaokar
trafficstars

I feel like it would be good to depend on serde and an argument parser at the least, `argh` is a popularish alternate argument parser with minimal deps

Besides, at least on GHA you can cache these installs

Would it be possible to rely on the `absolution` crate for this? That crate is explicitly designed for avoiding a `syn` dep but getting full token parsing

This blocks zero-copy japanese era data (part of https://github.com/unicode-org/icu4x/issues/1116) since that uses TinyStr

¹not tax-deductable

Deref it and match against string

oh, good point. Might be worth making a macro for matching then

I wonder if `tinystr16!()` can be written as a const fn now that that's stable if so it's _possible_ `TinyStr::new("en") => ...` might work (?)

> if so it's _possible_ `TinyStr::new("en") => ...` might work (?) Ah, this is still not allowed. I think a custom match macro is probably your best bet There is...

I think the other two are good too.