Manish Goregaokar
Manish Goregaokar
I think this is good. We can keep the old calendrical implementation around in `calendrical_calculations`, and potentially even expose a non-AnyCalendar calendar called `ChineseAstronomical`.
> Decide if the calendar offered by ICU4X is meant to match "truth on the ground" on this point, and potentially special-case this. We do intend to match the ground...
See the from_fields PR: there are a couple cases where we have a choice between a reference year in the far past and a reference year in the near future,...
@zbraniecki Questions from 2.0 triage: - Is this still an issue? - Should this still be a 2.0 blocker? - What parts of it are a 2.0 blocker? - Do...
> Have a `Temporal` dom object, with all methods, like [`Temporal.PlainDate`](https://tc39.es/proposal-temporal/#sec-temporal-plaindate-objects), being constructors(note the `NewTarget`, which is a [constructor](https://tc39.es/proposal-temporal/#sec-temporal-createtemporaldate)). If I recall correctly, the Servo script/DOM crate is not well-equipped...
I don't really find this to be unnecessary line noise. The `#[doc]` tags are produced by bindgen after parsing doc comments on the C++ side: they're taking comments meant for...
I wonder if we should demote this to a nursery lint until then? Thought: Without parsing _every_ line as markdown, we can save some performance by only running this check...
Yeah, I don't think this is the right fix. We should use the right spans whilst linting. Why is this lint emitting duplicate diagnostics?
I'm not actively fixing things here but accepting PRs, so I'm probably not going to investigate this, but happy to accept a PR. I do know that for tools like...