rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

remove `deduplicate-diagnostics=no` in `suspicious_operation_groupings.stderr`

Open kyoto7250 opened this issue 1 year ago • 1 comments

a part of #12379.

In this PR, we will update the lint to store already outputted Spans internally to prevent suspicious_operation_groupings from outputting the same error multiple times.

changelog: Fixed duplicate errors in suspicious_operation_groupings.

kyoto7250 avatar Aug 13 '24 14:08 kyoto7250

r? @Centri3

rustbot has assigned @Centri3. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Aug 13 '24 14:08 rustbot

r? rust-lang/clippy

Centri3 avatar Sep 13 '24 16:09 Centri3

Yeah, I don't think this is the right fix. We should use the right spans whilst linting.

Why is this lint emitting duplicate diagnostics?

Manishearth avatar Sep 13 '24 17:09 Manishearth

:umbrella: The latest upstream changes (presumably #13440) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Sep 22 '24 19:09 bors

:umbrella: The latest upstream changes (possibly d28d2344d000aa96bef729cf408731f952f71fb0) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot avatar Mar 31 '25 23:03 rustbot

Closing because no activity and not the right fix.

flip1995 avatar Apr 01 '25 09:04 flip1995