Manish Goregaokar

Results 1228 comments of Manish Goregaokar

2.0 work: audit and fix any stragglers. Shane thinks TimeZone APIs are missing this.

CaseMapper doesn't have a Borrowed type and probably should?

I'm open to this. I'd love to overall reduce the amount of generated stuff in tree though.

_actually_ I'd like us to run tests on all three primary data formats (baked, blob, json), generated at CI time, so that we don't accidentally e.g. break zerovec postcard deserialization

> _actually_ I'd like us to run tests on all three primary data formats (baked, blob, json), generated at CI time, so that we don't accidentally e.g. break zerovec postcard...

> I don't think we get too much value of running tests on top of that? There are a lot of different efficient ways of reading the data, especially for...

> the same code inlining will always happen, right not quite: we can't guarantee this, but users can guarantee this by wrapping things in a const or static the ability...

> Testing with JSON data, as justified in the OP. (I suspect Robert was talking about user-facing issues?) I think this can also be done by moving most non-docs tests...

That also gives us time to see if folks really like our const APIs or not.