chore(deps): Bump `@metamask/ppom-validator` from `0.32.0` to `0.35.0`
Description
### Changed
- **BREAKING:** Bump `@metamask/ppom-validator` from `0.32.0` to `0.34.0` ([#11114](https://github.com/MetaMask/metamask-mobile/pull/11114))
To fully align the dependencies, a new release of ppom-validator will need to be released with version bumps for @metamask/{base-controller,controller-utils,network-controller,utils}.
Related issues
- Closes https://github.com/MetaMask/metamask-mobile/issues/11134
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
- [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using JSDoc format if applicable
- [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@metamask/[email protected] | None | 0 |
122 kB | metamaskbot |
| npm/@metamask/[email protected] | None | 0 |
165 kB | metamaskbot |
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: 6d4b759dd61e6ba421b80bc49c2170ab6aacfcaf Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/92fdced6-05fc-40a8-9fd6-7bca309ec297
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅
Commit hash: bdfb873c99db9ceeb9440a5c3368f7db942c7123 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7d3aa337-b597-451d-b704-96e1f827ec69
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
Bitrise
❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌
Commit hash: eeddb08b27daaf98ff00e4b47ea3b589c9b87759 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2280079e-4baf-4616-a6e4-4fdaa9e3a8e0
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipelineon Bitrise by removing and re-applying theRun Smoke E2Elabel on the pull request
[!TIP]
- Check the documentation if you have any doubts on how to understand the failure on bitrise
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 54.64%. Comparing base (
b0ef1a7) to head (ea3eb0c). Report is 62 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #11114 +/- ##
==========================================
+ Coverage 54.27% 54.64% +0.37%
==========================================
Files 1711 1743 +32
Lines 38712 39355 +643
Branches 4738 4879 +141
==========================================
+ Hits 21010 21505 +495
- Misses 16253 16356 +103
- Partials 1449 1494 +45
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
We currently have four different @metamask/network-controller major versions in the dependency tree:
v21
=> Found "@metamask/[email protected]"
info Has been hoisted to "@metamask/network-controller"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "5.07MB"
info Disk size with unique dependencies: "17.91MB"
info Disk size with transitive dependencies: "39.14MB"
info Number of shared dependencies: 60
v20
=> Found "@metamask/smart-transactions-controller#@metamask/[email protected]"
info This module exists because "@metamask#smart-transactions-controller" depends on it.
info Disk size without dependencies: "3.17MB"
info Disk size with unique dependencies: "15.18MB"
info Disk size with transitive dependencies: "36.98MB"
info Number of shared dependencies: 59
v19
=> Found "@metamask/polling-controller#@metamask/[email protected]"
info This module exists because "@metamask#polling-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58
=> Found "@metamask/assets-controllers#@metamask/[email protected]"
info This module exists because "@metamask#assets-controllers" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58
=> Found "@metamask/gas-fee-controller#@metamask/[email protected]"
info This module exists because "@metamask#gas-fee-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58
=> Found "@metamask/selected-network-controller#@metamask/[email protected]"
info This module exists because "@metamask#selected-network-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58
=> Found "@metamask/smart-transactions-controller#@metamask/transaction-controller#@metamask/[email protected]"
info This module exists because "@metamask#smart-transactions-controller#@metamask#transaction-controller" depends on it.
info Disk size without dependencies: "676KB"
info Disk size with unique dependencies: "11.88MB"
info Disk size with transitive dependencies: "33.69MB"
info Number of shared dependencies: 58
v17
=> Found "@metamask/swaps-controller#@metamask/[email protected]"
info Reasons this module exists
- "@metamask#swaps-controller#@metamask#gas-fee-controller" depends on it
- Hoisted from "@metamask#swaps-controller#@metamask#gas-fee-controller#@metamask#network-controller"
- Hoisted from "@metamask#swaps-controller#@metamask#gas-fee-controller#@metamask#polling-controller#@metamask#network-controller"
info Disk size without dependencies: "452KB"
info Disk size with unique dependencies: "11.67MB"
info Disk size with transitive dependencies: "35.82MB"
info Number of shared dependencies: 59
This version mismatch is visible through TS errors, but it is hard to say if some functionality is broken as well, and very hard to tell by looking at Changelogs since a lot of things changed between these NetworkController major versions
@mikesposito can we replace this PR with https://github.com/MetaMask/metamask-mobile/pull/12225 ? which is now all green.
@cryptodev-2s definitely, thanks for pointing that out!
I'm closing this one.