Luke Lashley
Luke Lashley
@sreisi generally core maintainers ask you not to ping them. They'll more than likely already get a notification every time you comment or commit. They have a lot of PRs...
> Some initial comments to get the review process going 👍 > > ../Frenck Very much appreciated! I will take care of these!
Whoever ends up doing the next review, be it frenck or whoever else (no rush obviously). Should I be adding in Virtual integrations for the actual utility companies that southern...
To be honest - I barely have enough time for the integrations I have right now, I don't need to add a third that I am responsible for. I'm going...
Okay looking at this, this is very strange. Your io9 seems to give rather different data than most other io9s we have seen. the manufacturer_data matches the 6/7 identically. I'm...
> I noticed that the docs mentioned YAML configuration. I don't think that will be accepted here per [ADR 0010](https://github.com/home-assistant/architecture/blob/master/adr/0010-integration-configuration.md#decision) integrations that communicate with a device/service should be config flow...
> Hello. I have a couple of comments which might help improve the code a bit as well as the component itself Thanks for the feedback! I agreed with everything...
> Thank you for keeping the initial PR small 👍 Of course! Thank you for taking the time to review.
> Lets rename this to the Anova integration as they have multiple products and we don't want to end up with a seperate integration for each device type in the...
I am planning to add authentication to be able to control the sous vide. It is best if I wait for this PR to be merged and then add authentication...