core icon indicating copy to clipboard operation
core copied to clipboard

Intellidrive reisinger

Open sreisi opened this issue 2 years ago • 4 comments

Breaking change

Proposed change

Adds the Intellidrive integration. Integration allows Reisinger sliding door operators connected to the Intellidrive add-on adapter to be controlled via Home Assistant and integrated as a door

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/26330

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

sreisi avatar Feb 21 '23 13:02 sreisi

Also seems like you have your proposed change under breaking change in your pr description

Lash-L avatar Feb 21 '23 19:02 Lash-L

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 22 '23 13:02 home-assistant[bot]

I have the message: "Merging is blocked Merging can be performed automatically once the requested changes are addressed."

Does that mean that I still have open tasks todo, or just that the workflow is awaiting the pending review? Sorry I am new to github

sreisi avatar Feb 23 '23 15:02 sreisi

I have the message: "Merging is blocked

Merging can be performed automatically once the requested changes are addressed."

Does that mean that I still have open tasks todo, or just that the workflow is awaiting the pending review?

Sorry I am new to github

Don't worry about it - just means you are waiting for a review. Nothing for you to do.

Lash-L avatar Feb 24 '23 01:02 Lash-L

I have the message: "Merging is blocked Merging can be performed automatically once the requested changes are addressed." Does that mean that I still have open tasks todo, or just that the workflow is awaiting the pending review? Sorry I am new to github

Don't worry about it - just means you are waiting for a review. Nothing for you to do.

Ok, great! thank you ;)

sreisi avatar Mar 02 '23 13:03 sreisi

@emontnemery do I have to make more changes, or do you think it is ok for the first version now?

sreisi avatar Mar 16 '23 11:03 sreisi

@sreisi generally core maintainers ask you not to ping them. They'll more than likely already get a notification every time you comment or commit. They have a lot of PRs they balance at one time and if everyone pings them it gets kind of chaotic.

image

If you look here - he has a review pending, so it's on his list.

You just have to wait for him to get around to it

Lash-L avatar Mar 16 '23 12:03 Lash-L

Shouldn't the integration be displayed on one of the project task boards? I can't find it anywhere there, or is that intentional?

I mean these boards: https://github.com/home-assistant/core/projects/4 https://github.com/home-assistant/core/projects/5

sreisi avatar Mar 28 '23 07:03 sreisi

i have been waiting for a review for almost 2 months now, has the pull request perhaps been forgotten?

sreisi avatar Apr 14 '23 09:04 sreisi

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jul 25 '23 07:07 github-actions[bot]

Not stale dear bot... it is awaiting our review.

frenck avatar Jul 25 '23 07:07 frenck

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Dec 08 '23 10:12 github-actions[bot]