core icon indicating copy to clipboard operation
core copied to clipboard

Add Southern company integration

Open Lash-L opened this issue 2 years ago • 2 comments

Proposed change

Southern Company is a energy company which owns 3 major power companies in the southeast, one in Georgia, Alabama, and Mississippi. this integration aims to allow customers in those regions to get their energy data into Home Assistant.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/26179

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Lash-L avatar Feb 09 '23 03:02 Lash-L

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 09 '23 12:02 home-assistant[bot]

Some initial comments to get the review process going 👍

../Frenck

Very much appreciated! I will take care of these!

Lash-L avatar Feb 09 '23 12:02 Lash-L

Whoever ends up doing the next review, be it frenck or whoever else (no rush obviously). Should I be adding in Virtual integrations for the actual utility companies that southern company owns/ users log into? They all share an api, but have different customers. Or should I add a virtual integration for the one I have tested ( Georgia Power)? Or is this not a instance of when a virtual integration should be used/ should it be in its own separate PR once this one is merged? Thank you!

Lash-L avatar Mar 02 '23 17:03 Lash-L

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 07 '23 18:09 github-actions[bot]

To be honest - I barely have enough time for the integrations I have right now, I don't need to add a third that I am responsible for. I'm going to close this issue - and if anyone comes upon it in the future, feel free to take the work I have done and I would be happy to help you get it up and running, but I don't want to be the primary code owner

If anyone wants to use this integration - you can use the HACs version of the integration: https://github.com/Lash-L/southern-company-hacs

Lash-L avatar Sep 11 '23 13:09 Lash-L