Luke Lashley
Luke Lashley
I had a chance to do it in the background of a meeting. Fixed here: #93488
I would also add into the description why only PG&E is supported and how future utilities could be added
@borski I'm not a core maintainer. My review doesn't matter for anything other than just trying to help out
> Please make PRs small and limit them to the smallest usable set. For example, remove the additional services, those can be added later. > > See also: > >...
Thanks for the feedback Allen. I handled some of the more simple tasks, and I'll spend some time tomorrow taking care of the more difficult tasks, i.e. pypi and config...
Thanks for the second pass Allen! I've gone through and made the changes, I'll make a note of pydantic and potentially add it down the line
@allenporter Yeah, I have some local changes in which I am changing it back to polling. Which comments in particular? I thought I resolved them all and I just did...
> Thanks for addressing all the previous feedback. (You got everything I previously asked for, thanks!) > > I think this is the last round and otherwise this looks good...
edit edit: You can ignore this for now and just wait for my implementation - I think I figured it out. > Up to you, i don't mind either way....
> The other cases seem like they are optimizations or improvements that can follow in future smaller PRs. (If you go with the first approach, its improving reliability by using...