Luke Lashley

Results 255 comments of Luke Lashley

Fixed issues with the tests and the fan speed bug.

did you cancel the codecov update Allen or did it just get cancelled based on time? I was gonna update branch to get it to pass, but I guess that...

I realized there was a potential problem where if you timed out getting the networking information or the networking wasn't available, you could be left with 0 devices and technically...

Hey allen, sorry to make another push, but I went through and fixed typing in the base package using mypy - so this iversion bump should theoretically make us slightly...

Sounds good - I'll add strict typing down the line. I ran it now just to see, and there are a few things I have to change in the package...

> This says "Merging can be performed automatically once the requested changes are addressed." so it may need re-review by the original requestor? Can't tell. Ah yeah - probably because...

Let me know if you need anything from me - I'd love to get it included in the 2023.05 release/ potentially even get a few other small additional features included...

Amazing! Thanks a ton allen!

Also seems like you have your proposed change under breaking change in your pr description

> I have the message: "Merging is blocked > > Merging can be performed automatically once the requested changes are addressed." > > > > Does that mean that I...