react-spectrum
react-spectrum copied to clipboard
adobe
(WIP) Dnd api simplification
Closes
✅ Pull Request Checklist:
- [ ] Included link to corresponding React Spectrum GitHub Issue.
- [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
- [ ] Filled out test instructions.
- [ ] Updated documentation (if it already exists for this component).
- [ ] Looked at the Accessibility Practices for this feature - Aria Practices
📝 Test Instructions:
🧢 Your Project:
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
TODOs:
- add tests for the new drag type/File/Directory filtering we've added to defaultOnDrop
- Address https://github.com/adobe/react-spectrum/pull/3266#discussion_r964190132
- add controls to the ListView story so we can turn on/off the util handlers
- Research how other DnD libraries handle deleting items from a list on drop
- This will determine onItemRemove's final place in the api (i.e. how do we communicate what dragged items were actually processed by the drop handlers)
- other todos sprinkled throughout the code
- fix tests in 16/17
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉
Build successful! 🎉