Tomasz Chabora
Tomasz Chabora
- [ ]  Ctrl is usually used for scroll to the end, so Ctrl and Shift should be swapped here IMO. - [ ] Scrolling to last element when...
For updating disable status, maybe connecting `value_changed` of scrollbar with CONNECT_DEFERRED would suffice? 🤔
Updating minimum size in `NOTIFICATION_DRAW` means that the Button's size is undefined until it's drawn for the first time. This can cause various sizing problems with containers.
Why was this closed?
Except not all were closed https://github.com/godotengine/godot/pulls/whalesstate 🤔 Some of the closed PRs were already approved and did not require further action. You can still restore the branch and reopen them.
The minimal right margin is smaller than the left one. Shouldn't they be symmetrical? 🤔  EDIT: It's symmetrical when `h_separation` is 0. Looks like the left side uses half...
So I did an experiment to test the new behavior. I made a StyleBox with 0 content margins and borders equal to `h_separation`. This way it's easy to visualize the...
Yeah, overall it's an improvement.
Rebasing is only needed if there are conflicts, or sometimes when a PR is very old and wasn't recently updated.
I did some tests myself (also Windows 10) Vanilla build 4714e9589, editor only:  Vanilla build, editor + game:  Your PR, editor only:  Your PR, editor + game:...