Tomasz Chabora
Tomasz Chabora
Still not convinced about slider max value change. While it's possible to input bigger number in the SpinBox, you lose ability to adjust overbright via dragging, and I know some...
With all these `get()` methods in ColorMode, I wonder if we shouldn't just introduce a single ColorModeConfig struct, which would hold all these parameters (not in this PR). `get_spinbox_max()` would...
Makes sense.
It seems to be missing some testing. See the checkboxes in the OP.
Maybe we could create some "init" file when starting editor and delete it once the editor loads. If it doesn't load it means it crashed. Though I suppose there are...
Well, this is not going to be merged before 4.4, so you have some time to improve it.
You renamed `_open_selected_projects_with_migration` method
> Since you're doing something similar, I saw fit to also rename it to _open_selected_project_check_migration. But the function performs the migration. The checks are technically done before the info dialog...
Parameter list doesn't work properly. It's not updated right when modifying shaders and some operations may replace it with nulls: https://github.com/user-attachments/assets/fdbcc7b9-83cd-4be8-bcd6-5d5162a8b6fd Other than that they look functional, which is nice.