Tomasz Chabora
Tomasz Chabora
I mean, it's what we have currently. And you can't really prevent it - the signal is emitted in the editor, received in the editor, the method is called because...
No this is working as intended. The signal calls a core method in a node, it can happen without any script. I don't think we can reasonably block calling non-script...
The methods are braindead simple and the only thing you can test is whether the converted container contents are the same. Not worth it IMO.
I pushed small improvements. I think this is good to go, but since it's a first of a series of PRs, we should agree on some things (even if some...
Maybe. But they are easier to manage in one place. EDIT: Another upside are compilation times. Modifying Vector or List would take forever.
I tried moving `vector_to_typed_array()` to Vector, but it doesn't compile: https://github.com/KoBeWi/godot/commit/679cceade9339bd15f5b4f284240380e94dbb377 I had to add `vector.cpp` and *I think* I did it right, but there are unrecognized symbols. No idea...
Changed the `change_type()` methods to not include `change_type()` in name, as its unnecessary.
@bruvzg Your commit has the implementation in the converters header, so it still needs to be included. I tried moving them to cpp files, but I get the same error...
So the only advantage of defining these methods in classes is that you get rid of namespace. You still have to include the conversion header. And you will likely get...
This could be an argument to the git methods. Not sure if it's worth it though, you are the first person to have this problem.