Tomasz Chabora
Tomasz Chabora
(t's not even approved) (also you can mark it as draft)
Ok pushed this as a second commit, but something is still wrong lol  Also it's funny how whole dialog moves 1 pixel when toggling Advanced mode:  Tree doesn't have any way to increase its size and I can't use custom minimum size, as it fits to window.
``` CrashHandlerException: Program crashed Engine version: Godot Engine v4.0.beta.custom_build (20d6672846b3fd1537603ac080116dcc914c10e3) Dumping the backtrace. Please include this when reporting the bug to the project developer. [0] TileSet::generate_terrains_icons (C:\godot_source\scene\resources\tile_set.cpp:1766) [1] TileSet::generate_terrains_icons (C:\godot_source\scene\resources\tile_set.cpp:1766)...
Fixing the crash is as simple as changing this https://github.com/godotengine/godot/blob/57ffc4d82c773a513c8d122d859f07759c8c7da3/scene/resources/tile_set.cpp#L1764 to `if (tile_data->get_terrain() >= 0 && tile_data->get_terrain() < bit_counts.size()) {` This results in empty preview  and this error: `core\io\image.cpp:2668...
But the PR is about `int("string")`. It no longer works in 4.0. I don't know how it works internally; if it causes implicit conversions then I agree it's bad :/
I checked and this ```GDScript var a: int a = "123" ``` does not work, so I guess it's fine? 🤔
Seems related (same?) to #5523
Warning sounds fine. It could show when the string is not constant, instead of error like now.
Non-strings for message don't really make sense.