Tomasz Chabora

Results 929 comments of Tomasz Chabora

It does completely nothing. Doesn't even update the button (you can see it's still white). I tested your PR and it doesn't fix this (it's probably not even related, because...

I opened a PR with alternative approach, which is more promising, but needs to be finished 🙃

Rebased and tested, it still works. Note that the editor measures the time it takes to load the scenes alone, not the overall project opening time. In my case it...

Here's the test scene with up-to-date script: [OrderOfNodes.tscn.txt](https://github.com/godotengine/godot-docs/files/13765848/OrderOfNodes.tscn.txt) Indeed the predelete thing looks like a bug. Other changes might've been caused by Godot 3 to Godot 4 transition.

The undo action uses generic `add_child()` method from Node and it has no information about the side-effects of this action. Resolving this would be tricky and require some special handing...

Yeah the problem is that Node has no size, so you first need to check if it's a Control and do this conditionally. Doable, but sounds hacky. Also you can...

I checked the code and the implementation seems fine, but changing return type still breaks compatibility. Although Array and PackedStringArray are mostly compatible so *maybe* it's not a big deal.

> That means I have to remove typing completely. Yes, that's the solution if you want to support older versions.

As I said in the chat, I think Controls should just have a configuration warning if their `z_index` is non-zero.