Tomasz Chabora

Results 931 comments of Tomasz Chabora

Custom icons need to be resized. ![image](https://github.com/godotengine/godot/assets/2223172/b979376d-21eb-49e5-a269-b14248355175)

> if you change the file name of a plugin's script, it will not create a new one with the new name. Now it does. I think it should first...

You can call `update_file()` in EditorFileSystem, or in worst case, just do `rescan()`.

And if you use this? https://github.com/KoBeWi/godot/commit/7c165a16cee88c03012ff20e5ba72d7dac9737f5 (`FileSystemDock::get_singleton()->rename_file()`)

I was going to look into it, but mixing the behavior change with such enormous refactor makes it unreadable. You should split this into 2 commit.

But includes are only needed when you inherit the class or define a method inside header. I checked these files and it doesn't seem to be the case there.

Wrong names are not reverted and display incorrectly: ![image](https://user-images.githubusercontent.com/2223172/206728971-ab39ae60-5281-4a32-a534-c93da2e89bfa.png)

> Restoring old_name from to_rename with some string magic which needs to handle file vs folders I think this would be preferred. There are no performance considerations here, but if...

> I fixed the wrong names not being reverted. Seems to be still happening. Tested on folders with duplicate names.

I don't like how `set_uid()` duplicates lots of code. Can't it just re-use the saving code?