Tomasz Chabora
Tomasz Chabora
Rebased again. I fixed the plugin issue I mentioned before by exposing EditorUndoRedoManager for scripting. The sanitizer issue still remains though.
Compatibility breaking would only affect editor plugins. While EditorUndoRedoManager has almost the same interface as UndoRedo, it requires doing extra steps in some cases and obviously it would break if...
> Seems good Which part xd I attached a few GIFs showing how much it is broken. The editor issues need to be resolved somehow, maybe by adding some helper...
> Confirming a change to a multiline cell is done with Ctrl+Enter instead of Enter. Should be the opposite.
I added some note about, I don't think anything more is necessary. I bet `null` as a Dictionary key is not used very often and even less with `find()`.
> assert message (2nd arg) is being commented out, which breaks code since it's required It's not required and is likely commented-out due to #47157
But what should go to project settings? This PR doesn't add any setting, it just remembers your choice in *project metadata*. So it's already per-project.
The setting could be moved, but another option is something like this: https://github.com/godotengine/godot-proposals/issues/1480 Whatever we decide, it should be done in another PR IMO.
> maybe just the scenes that take the longest should be closed if this is the case? When though? Editor is completely frozen when loading a scene and afterwards the...
Ah you seem to be right. The order is still different though.