KevinOConnor

Results 194 comments of KevinOConnor

On Sun, Jun 03, 2018 at 06:45:28AM -0700, Hans Raaf wrote: > I also got an error related to timing. When I set pressure advance to 5.0 I immediately get...

This issue is limited to a specific gcode sequence on the Replicape. If you're seeing a "timer too close" error on a ramps it is not related to this. A...

As noted, it's not valid to use templates from the command line. However, I agree Klipper should not have raised an "internal error" in this case. -Kevin

Thanks. I'm fine with merging this. (There are likely 100 of the above "esc boards" and the changes appear sufficiently "modular" to me.) Some minor comments to follow. -Kevin

Thanks. Looks fine to me. Yes, if you could rebase this to squash in the fixes that would be great. (Ideally keeping the lib/ updates its own separate commit.) -Kevin

Thanks. Configs need to follow the guidelines at https://www.klipper3d.org/Example_Configs.html . At a minimum points 4, 6c, and 7. The `flash_usb.py` script is only intended to flash USB targets - it...

Thanks. The config looks fine (though it would be preferable to state "enable usart(on pins x and y)" in the comments as opposed to saying "disable usb". I don't agree...

Thanks. However, the example configs need to follow the guidelines at https://www.klipper3d.org/Example_Configs.html (at a minimum point 4). You will also need to provide a signed-off-by line - see: https://www.klipper3d.org/CONTRIBUTING.html ....

> The maximum build height should've been around 230mm instead. True, Klipper could have done better here. Your delta arms are a little shorter than most delta printers, and the...

> I could override the value of "self.max_z" in kinematics/delta.py for the duration of a print FWIW, I think adding a new "print_radius_taper: True" option to the config may be...