KevinOConnor
KevinOConnor
What is the status of this PR? -Kevin
FWIW, this PR looks okay to me. I only gave it a superficial review though. Hopefully @arksine can provide any additional feedback - in particular on the changes to spi_flash.py...
Thanks. Looks like this PR just needs a rebase (to fix some minor merge issues) and confirmation from @CyberDeck that it is still good to be merged. -Kevin
Thanks. I committed this change (commit d7bd7f1f). However, I did not commit the change to board_defs.py as that looks to me like a non-backwards compatible change that would need an...
Interesting. FWIW, I'm not sure it needs to be in the mainline Klipper branch though. Cheers, -Kevin
Thanks! I have some high-level comments: 1. This functionality looks useful and I think it is worthwhile to add to Klipper. 2. The interaction between bed_mesh.py, probe.py, and probe_eddy_current.py looks...
Hi. Sorry - been super busy the last couple of weeks. > > The code flow and data requirements between bed_mesh.py, probe.py, and probe_eddy_current.py seem complex. I wonder it there...
Thanks again for working on this. Again, sorry for the delay in responding. My main feedback is that I think we should refactor the probing interface prior to merging this...
Thanks. Alas, I haven't been able to get time to look at this. I'll be travelling for a couple of weeks, but will hopefully get a chance to comment when...