KevinOConnor

Results 194 comments of KevinOConnor

Thanks. Sounds like this is resolved now. -Kevin

Thanks. It's fine with me, but I'd really like someone to help with reviews of lcd and menu changes. Cheers, -Kevin

Thanks. In general it would be great if someone would take on reviews of the menu. I don't use an lcd menu on any of my printers, so it is...

Thanks. I agree this is useful functionality to add. I think it would be preferable to reduce the number of compile time "ifdefs" though. How about something like the below...

On a closer look, I think I misunderstood the changes you made to armcm_reset.c, thus the diff above isn't complete. I'm leery of adding board specific code to the src/generic/...

Thanks. I'd prefer to avoid the "ifdefs" in the makefile if possible. How about PR #5874 as an alternative? -Kevin

Sounds like you are looking for PR #5767. If not, you'll probably want to open a new topic on Klipper Discourse, as we don't use github issues to investigate issues...

Thanks. Looks fine to me, but it needs a rebase as github shows this PR as having a conflict. -Kevin

Thanks. As background, g-code has some very arcane rules on how g-code messages are to be processed. Klipper follows the rule that for every newline character (aka '\n', aka 0x0A)...