Stefan Kerkmann

@tzarc I would like to have your opinion on this implementation as well before merging, as you wrote and designed the system in the first place.

> @KarlK90 Doesn't that count as “changing user code en masse”, which @fauxpark advised against, in [this comment on another PR](https://github.com/qmk/qmk_firmware/pull/15286#issuecomment-980780290)? Probably, but I would argue that 9 keymaps (1...

> @KarlK90 Do you mean only removing it from keyboard-level config.h files as I've done in commit [ab78408](https://github.com/qmk/qmk_firmware/commit/ab78408494d878d62c0c1640ad2ada55d36f1ca1) or should I also remove them from users' keymap-level config.h files? As...

I tried out the changes on my keyboard and everything works as expected, very well done you have my approval. Only thing left is that some `IGNORE_MOD_TAP_INTERRUPT` defines silently sneaked...

> I should almost somehow subscribe to keymap PRs like #16696 getting merged so that I can prevent more `#define IGNORE_MOD_TAP_INTERRUPT` from sneaking in under my nose. As part of...

Has merge conflicts after #17284 would you mind converting the tests to `EXPECT_REPORT`, `EXPECT_EMPTY_REPORT` and `EXPECT_EMPTY_REPORT`?

> Would it be better if I extracted commits purely related to `HOLD_ON_OTHER_KEY_PRESS` like [f64861a](https://github.com/qmk/qmk_firmware/commit/f64861ac2008b5c284826adcb8cfd07fb9a33fd4) and [9b9d411](https://github.com/qmk/qmk_firmware/commit/9b9d411997a28bc70fe28748c98ffaceb841afa5) into another PR? From my side it is fine to keep these in...

@sigprof That is some great feedback, I have incorporated your suggestions and will answer tomorrow in greater detail.

> @KarlK90 I had to make these [changes to retro_tapping/test_tapping.cpp](https://github.com/qmk/qmk_firmware/pull/17007/files#diff-4b81ab6267e32bf671729efaa23c6fb9283420208e8305f420861b97805afa9c) for the unit test to pass this PR. Does the parameter name `ANewTapWithinTappingTermIsBuggy` mean what it says? The changes are...

Hi @hathach out of curiosity I ran the MSC demo again with the latest changes to master and... ``` [Sa Nov 27 12:25:14 2021] sdc: [Sa Nov 27 12:25:14 2021]...