qmk_firmware
qmk_firmware copied to clipboard
[Core] guard RPC invocation by checking RPC info against crc checksum
Description
In case the RPC info data was corrupted during transmission we prevent the execution of bogus data.
Types of Changes
- [x] Core
- [ ] Bugfix
- [ ] New feature
- [x] Enhancement/optimization
- [ ] Keyboard (addition or update)
- [ ] Keymap/layout/userspace (addition or update)
- [ ] Documentation
Issues Fixed or Closed by This PR
Checklist
- [x] My code follows the code style of this project: C, Python
- [x] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
@tzarc I would like to have your opinion on this implementation as well before merging, as you wrote and designed the system in the first place.