Stefan Kerkmann

Results 88 comments of Stefan Kerkmann

> Should this recommended change to `is_tap_record` be added in this PR or in another distinct one? I've opened #18063 to fix this issues :slightly_smiling_face: (already merged) > Restored the...

@filterpaper with the merge of #17281 this PR unfortunately has conflicts and needs a rebase.

@filterpaper you're rebase unfortunately doesn't contain the changes you did earlier to [`action_tapping.c`](https://github.com/filterpaper/qmk_firmware/blob/quick_tap_term/quantum/action_tapping.c#L173-L179) and some usages of `TAPPING_FORCE_HOLD` and `TAPPING_FORCE_HOLD_PER_KEY` sneaked into the code base in user code as well....

Thanks for the kind words! Sorry for the late response, I didnt see your issue earlier. As the board uses an mcu directly soldered to the PCB this would need...

@Visne thanks for the reminder. You want this kind of brass standoffs: ![image](https://user-images.githubusercontent.com/13887561/208875086-f19dfa1a-6cb9-4953-a4e8-8153622d2d0f.png) > I was also wondering whether you could add AliExpress links to the table, because for the...

@infinityis #22905 got merged before your PR, could you rebase once more?

> > the regular key codes assigned to the keys are not important and must not be sent > > 1. Some Windows PCs do wake up on usb remote...

@tbowmo please try my PR #21656 if this fixes the issues you are seeing.

@rubienr thanks for your PR. It looks good in principle but there are now falling unit-tests as you have changed the behavior. This has to be fixed in order to...

I guess I have to bring out my USB analyzer once more.