Stefan Kerkmann
Stefan Kerkmann
> In future I would rather you didn't, and let me know. Its not like i'm not active. Understood. Is collaboration on your PRs generally not welcome or were the...
> Pushing to someone elses branch without notice isnt collaboration. Force pushing, thats just hostile. I didn't mean to be hostile and I'm sorry that it came across as such.
Hi @j-hap there are merge conflicts, would mind rebasing your PR?
@bryan065 the existing rgb to rgbw conversion is very basic. I do not have any rgbw leds so I can't test any different algorithm for the conversion but maybe give...
@griffingarland could you post the output of the `qmk doctor` command?
Thanks for the feedback! The breakage is not intentional, I have added tap delays to the unregister process and those keycodes should be working again!
Fixed both the typo and the warning. Thank you for the feedback.
Rebased my commits onto develop and squashed my commits into a single one. Should be good to merge now.
Oh well, I guess this is the point where more unit-tests have to be added to spot regressions like this. I'll see what the root cause is and add those...
@drashna I have added some more one shot modifier and one shot layer unit-tests that pass on develop and only without the changes of this pr. BUT the default behavior...