Joseph Eng

Would #6324 fix this?

Note that `toArray(T[])` will automatically try to reuse the passed array, so a simple way to reduce allocations would be to update the array with `m_composedCommandsCopy = m_composedCommands.toArray(m_composedCommandsCopy)`. (There's some...

Was this issue completely resolved? The linked PR was changed to only update examples.

That would be a nice way to do it, but at first glance I didn't find an easy way to get a task that has access to the `DeployContext`, but...

Personally, I would be okay with `loose`, but I would prefer `proxy` since `loose` doesn't immediately come to mind and `proxy` is already used in commands.

Overall, good work! Just don't want us to forget that this still needs unit tests and ports to other languages (including [robotpy/robotpy-commands-v2](https://github.com/robotpy/robotpy-commands-v2) after this is merged). I'm also still a...

> The `RepeatCommand` has a fatal race (it always loses) with the `ProxyCommand` that is being used to `disjointSequence` so the repeated results are wrong. Could you elaborate more on...

Thanks for noticing that bug! It turns out to be a fairly involved bug, and I think the cleanest fix would be #6593. This is what happens during the call...

The cases I could find: * `CommandScheduler.cancel(Command...)`- Having a `Collection` overload would probably be fine, but there isn't a clear use-case for canceling a `Collection`, and in general we avoid...

You need to use `std::move(commands)` instead of `commands` to move ownership of the commands to the SelectCommand, and you might want to `std::move(selector)` as well.