Joseph Eng
Joseph Eng
Looks like this would be your first time contributing, so if you plan to contribute this yourself it would be good to read over the [code of conduct](https://github.com/wpilibsuite/allwpilib/blob/main/CODE_OF_CONDUCT.md) and [information...
For the ~~bean counters~~ instruction counters out there, below is an implementation that avoids any square root, division, or trig operations: ```java // || (||v||² v) || = ||v||² ||v||...
What if instead of `put()` it was named `addEntry()`, `withEntry()`, or something else which doesn't have an existing meaning/convention like `put()`?
> > Although this uses two separate lists to avoid having to allocate Pair objects > > Use LinkedHashMap, which preserves insertion order. I would use `LinkedHashMap` and `LinkedHashSet` (even...
After thinking about this some more, I've decided that it makes sense for this PR to make the minimal changes to define the order of iteration (so yes I'll be...
Based on https://stackoverflow.com/questions/66122388/is-it-possible-to-walk-stack-frames-from-an-exception and looking through the [`StackWalker` docs](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/StackWalker.html), I'm not sure the complete issue would be feasible. (We can do some parts of it but not all of it)...
I agree that copying `scheduledCommands` would be the cleaner solution. Some things to remember for whoever implements that: * Make the same change to Java (I think iterating over `m_scheduledCommands.toArray(new...
This was stated in Discord, but tests are probably failing because of an inconsistent order of when the commands in the internal deadline group are checked, which should be fixed...
[std::ranges::key_view](https://en.cppreference.com/w/cpp/ranges/keys_view) is an alias of [std::ranges::elements_view](https://en.cppreference.com/w/cpp/ranges/elements_view), which requires that the container (in our case, `wpi::DenseMap`) satisfy [std::ranges::view](https://en.cppreference.com/w/cpp/ranges/view) and be tuple-like (Or maybe the element type (in this case `wpi::detail::DenseMapPair`) be...
The `toTwist2d(SwerveModulePosition... moduleDeltas)` implementation expects each swerve module position to contain the translation of each wheel in polar coordinates, based on matching the implementation to the derivation in the swerve...