Joseph Eng

(Note for myself so I don't forget) Peter: > I’m still a bit on the fence re: the remove_prefix PR. I don’t really like the repeated string, and for a...

I'm not the happiest with a few of the translations- I think Peter had a really good vision for the most common use-case, but some of the odder occurrences were...

Is this now redundant from #6296?

> documenting the individual struct members and units thereof is not yet done So there is expected to be people writing their own struct implementations?

Although it would be fairly easy to migrate, I don't think it would be good to introduce a breaking change like this one so close to kickoff (1 month left,...

Would an approach like [the `Requirements` struct](https://github.com/wpilibsuite/allwpilib/pull/5504) work? (Defining a struct with implicit conversions from everything needed?) I think that would allow the functions to remain non-templated.

It probably should be fine, especially since most teams won't need to use `ToPtr()` (unless for some reason they're upcasting their pointers to `Command*`, but that probably won't happen).

> > unless for some reason they're upcasting their pointers to Command*, but that probably won't happen > > Wdym? I might be wrong, but as I understand it, the...

Could you please send the code that reproduced the issue? I'm glad that there's a workaround, but I'd like to see if there's a root cause that can/should be fixed.

This PR is technically breaking because now including `AprilTagFields.h` doesn't include the declarations in `AprilTagFieldLayout.h`. I \*could\* fix this by adding `#include "frc/apriltag/AprilTagFieldLayout.h"` at the bottom of `AprilTagFields.h` (I tested...