Joseph Eng

Results 113 comments of Joseph Eng

The reason to target development is that we don't want to break users in the middle of a season (even if it is a fix that restores expected behavior). For...

Does this address all of #5039? (except for moving to a subdirectory or subpackage, which was already shot down)

Sounds good, though now there's the question of whether or not all of the protobuf headers should be like that for consistency. I could potentially see people getting tripped up...

I decided to remove the declaration includes from the main header files so that it would be a compilation error instead of a linkage error. I don't understanding what's going...

Weird that Windows didn't recognize `wpi::Protobuf::New` earlier (see [this CI run](https://github.com/wpilibsuite/allwpilib/actions/runs/6974874925/job/18981195738#step:10:427)), especially since the Matrix version worked just fine. Maybe it had something to do with recognizing the using declaration?...

Thanks for that advice! I don't know how long it would've taken me to figure that out otherwise, though now I need to figure out why it can't find the...

I tried removing the export in https://github.com/KangarooKoala/allwpilib/commit/79d01c8cda1d55219f38eb3e8267c15336377be5 (on the other branch) and [the error message](https://github.com/KangarooKoala/allwpilib/actions/runs/7039430657/job/19158390651#step:10:455) stayed the exact same... Curious that the methods it can't find are defined by the...

The branch I've been testing on should be up to date on main (https://github.com/KangarooKoala/allwpilib/tree/tmp-more-serialization), though I could try updating this one as well if you'd like.

Merge conflicts are because of the changes to Spline, but I can't implement `wpi::Struct` because it can't deduce `Degree` from `frc::Spline::ControlVector` (https://stackoverflow.com/a/42391871). I might be able to make a workaround...

Thanks for the help, but we can't export all symbols in wpimath because there'd be too many. I've messed around trying to fix this (see [KangarooKoala/try-export-macro](https://github.com/KangarooKoala/allwpilib/tree/try-export-macro), [KangarooKoala/tmp-more-serialization](https://github.com/KangarooKoala/allwpilib/tree/tmp-more-serialization), and [KangarooKoala/try-protobuf-generate](https://github.com/KangarooKoala/allwpilib/tree/try-protobuf-generate)), but...