allwpilib
allwpilib copied to clipboard
wpilibsuite
Use Jinja to generate HID classes
Uses Jinja templating to autogenerate HID classes (with sim classes) from a JSON file.
How much do we care about reasonably good JavaDoc/doxygen? The JSON is less than DRY to cover the nuances of documentation form vs. code/CamelCase form. Making the JSON more DRY would mean either the template becomes more messy, or the documentation becomes a bit more clunky.
How much do we care about reasonably good JavaDoc/doxygen?
The HID classes are used often, so the docs for them should be good.
The generated files should pass all formattters and linters, since we include the generated source in the repo precisely so developers can read it. We haven't had to make exceptions in that regard so far except for Checkstyle.
The generated files should pass all formattters and linters, since we include the generated source in the repo precisely so developers can read it. We haven't had to make exceptions in that regard so far except for Checkstyle.
We'll need to make an exception for wpilibc since the BooleanEvent methods in the .cpp files are right on the line length border, so we need to exclude them from formatting.
I turned the button names into an array so I can capitalize the individual parts and join them. Not sure if that's what you wanted, but it is less fields. (With a bigger JSON file because formatting)
Does this address all of #5039? (except for moving to a subdirectory or subpackage, which was already shot down)
Idk what the wpiformat and clang-tidy include-what-you-use failures are from. We didn't change wpiformat, and this PR doesn't touch the files it's complaining about.
Does this address all of #5039? (except for moving to a subdirectory or subpackage, which was already shot down)
Yes, all game controllers are codegenned. Joystick is not codegenned because I think it's different enough to maintain separately.
Looks like you nuked your changes during a rebase. Use git reflog and git reset --hard to get them back.
I have it saved on a local branch. Trying to make sure wpiformat works with "no" changes.
