allwpilib icon indicating copy to clipboard operation
allwpilib copied to clipboard

Add command.repeatdly(int count) to both java and c++

Open kytpbs opened this issue 1 year ago • 4 comments

Currently, the unit tests fail and there are a lot of print statements for whoever might be checking into this.

The problem is. The exact same function calls create different results between C++ and Java. I may just be the idiot but it seems to require further look into

The debug's are in different commits making it a lot easier to revert them if needed.

kytpbs avatar May 06 '24 00:05 kytpbs

/format

kytpbs avatar May 06 '24 12:05 kytpbs

This was stated in Discord, but tests are probably failing because of an inconsistent order of when the commands in the internal deadline group are checked, which should be fixed by #6602.

KangarooKoala avatar May 12 '24 21:05 KangarooKoala

Thanks to #6602 being merged, the tests pass correctly.

I reverted back the print code and rebased them out for a cleaner history.

kytpbs avatar Oct 07 '24 01:10 kytpbs

fix formatting with rebase + force push:

kytpbs avatar Oct 10 '24 22:10 kytpbs

/format

kytpbs avatar Dec 16 '24 14:12 kytpbs

Force pushing to rebase with main and revert the format commit (broke the entire PR lol)

kytpbs avatar Dec 16 '24 15:12 kytpbs

/format

kytpbs avatar Jan 31 '25 18:01 kytpbs