JosJuice

Results 236 comments of JosJuice

The thing is that you only see the constness if you go and look up the function signature. When you're reading through code that's calling a bunch of functions you're...

> I'm not sure if on a real Wii disc a partition is always full group sized; this could be solved in other ways too if needed. No, they're only...

This code is designed so that if the offset is out of bounds, the check against `partition_data_decrypted_size` is supposed to stop the read from happening. So this smells like something...

While alignment exceptions turned out to have nothing to do with issue 12565, alignment exceptions are still something that would make sense for us to emulate (even if it doesn't...

I tested the intro of Wind Waker on my laptop now, and unfortunately it's significant. At the most lightweight part of the intro I got around 80 FPS without checking...

The translatable terms are "Control Stick" and "C Stick". See PR #3033.

> Do I need to account for this PR: https://github.com/dolphin-emu/dolphin/pull/10162 ? If you're not touching Jit64, you don't need to touch JitArm64 either. And if you're not touching JitArm64, you...

This is just my personal opinion and not my opinion as the Android maintainer, but that behavior just seems weird to me. I've never seen an app behave like that.

If you want to go with the display name approach, I would suggest prepending "ID-" to the game INI name, to match how we handle DOL and ELF files. Also,...