JosJuice
JosJuice
Yes, now that you mention it, I think this will fail for non-ASCII paths on Windows. Instead of implicitly converting std::string to std::filesystem::path, which uses the system codepage, please use...
No. Converting to the system codepage is a lossy operation (except for certain codepages), so if we are in a situation where we have a string that's in the system...
> oh - dolphin's `string`s (at least the ones passed to FileUtil) are already utf8? Yes. > If that's the case...it doesn't seem it should be too hard to switch...
I forgot to mention, but the OS support situation for nogui is currently the same as for DolphinTool. I suppose nogui is more likely to break Windows 7 support in...
Ah, in that case I suppose you can ignore my comments.
> i might be wrong, but since this is something that was a thing in some really old versions of dolphin, shouldn't this be called "Reimplement preliminary Triforce support" instead...
What is the copyright status of the added image files?
Because you've added an entry in the middle of the Platform enum, you must make a change to the Android code, otherwise the Android enum will be out of sync...
> So are you saying that I should implement the code you posted or scrap all of the android code until games can run? That you should implement the code...
Yes, preferably.