JosJuice
JosJuice
That's odd. I'll retrigger the builder and we'll see if it was just some temporary failure.
"GBAProfileX" is already implemented in InputConfig.cpp, so it makes sense to me to use the same approach here.
There's nothing you need to do right now. I'm waiting for someone else to also review the PR.
Normally we avoid forcing EFB to RAM if it's just for a small thing like this, due to performance concerns... But I don't know, maybe this game is super lightweight?
This is okay for FifoCI, but for regular users I think this is unacceptable unless it's put behind a toggle. You say that "it's very easy to size the window...
> I was indeed wondering what happens if the game changes resolution while recording. Theoretically this was already an issue before, as if `bInternalResolutionFrameDumps` was false, the video/output size could...
> I had skipped on implementing BranchWatch on JitArm64 because the Branch Watch Tool is unavailable on Android, but I forgot Windows on ARM is also a platform Dolphin supports....
Dolphin does handle SYSCONF settings changing while emulation is running, but the new values don't get read until emulation ends: https://github.com/dolphin-emu/dolphin/blob/d89a0423d191931b31cafd8c2256a5258778dcb4/Source/Core/Core/BootManager.cpp#L228
Could we avoid using the terms "EFB2RAM" and "EFB2Tex" in the graphics mod descriptions? We stopped using those terms in the GUI about 8 and a half years ago, so...
Couldn't we match it with the name used in the GUI? So "Automatically disables Store EFB Copies to Texture Only[...]"