Jonathing
Jonathing
Thank you @PaintNinja for bumping ASM on all newer versions :saluting_face:
I have a couple of issues with this initial implementation. First, it seems like your adding *vanilla* data components instead of Forge data components. Why? i.e. `minecraft:sweep` is what it...
> but that's why we test test test yuuppppp 💀🤡💀🤡 Hopefully ForgeDev 7 will enable some tools to make testing even easier
> How much commenting do we want to do with the new build script? Parchment should get its own comment. AccessTransformers and Mixin need to be mentioned in a way...
Yes, they did mark these events as internal. But I'm still going to need to test this on all the kitchen slop packs since it's entirely possible that there could...
Assigning myself to this issue as I am blocking its merge until I've tested it.
I understand why Paint made this. These events are marked as internal, after all. But I am all too aware that implementations do not have to respect those annotations. The...
We can't merge this as it currently stands. I've tested against Better Minecraft 4 and All of Create, and they both crash on startup due to a mod attempting to...
Re-assigning to Lex, as I am having difficulties testing this on my setup. Unsealing all events in `RenderTooltipEvent` seems to fix initial crashes on all the modpacks I've tested, but...
We have a test mod demonstrating the usage of vanilla's data generator. We are open to documentation contributions for this.