Jonathing

icon indicating a website link https://jonathing.me icon indicating an email [email protected]

icon company @cryptic-mushroom icon location East Coast, United States icon location Organization manager for @cryptic-mushroom, service maintainer for @Modding-Legacy, and core team member of @MinecraftForge.

Results 178 comments of Jonathing

[1.20.6] Bump CoreMods and ASM

Here is the log output for JarCompatibilityChecker ``` net.minecraftforge:coremods:5.1.6 -> net.minecraftforge:coremods:5.1.13 java.lang.IllegalArgumentException: Class net/minecraftforge/forgespi/coremod/ICoreModProvider was not found in class info cache or JVM classpath at net.minecraftforge.jarcompatibilitychecker.core.ClassInfoCache.getClassInfo(ClassInfoCache.java:191) at net.minecraftforge.jarcompatibilitychecker.core.ClassInfoComparer.getParentClassNames(ClassInfoComparer.java:380) at net.minecraftforge.jarcompatibilitychecker.core.ClassInfoComparer.compare(ClassInfoComparer.java:88)...

[1.20.6] Bump CoreMods and ASM

This PR is ready to merge. There are no changes in transitive dependencies since the last version of CoreMods that Forge for 1.20.6 has shipped, that being 5.1.6.

Add more `c` fluid tags

I would also vote in favor of a once-a-week check for c tags, since that's still rather frequent. There will inevitably come some painful week where these common tags have...

Add more `c` fluid tags

Since this PR has not been merged yet, I'm going to hold off on making a port to 1.21.3 for now. Assuming this PR is still targeting 1.21.1 (which it...

Cleanup ProjectileImpactEvent hooks and add tests for non-default cases.

This will need to be rebased once #10338 is merged.

[1.21] Remove the need for ModEventBus's.

Remind me, what's the reasoning behind this one?

[1.21] Remove the need for ModEventBus's.

What about existing parallel events such as FMLCommonSetup or RegistryEvent?

[1.21] Remove the need for ModEventBus's.

Ah ok, thank you!

(1.20.1) Adds Capability for Mods to Register Custom Brewing Fuels

Closing as stale. I like the idea, but it hasn't been updated in a while and also hasn't been requested of anyone else. We discussed this on Discord before, but...

Use a delegate object for `MonitorAware` events

If we want to keep future Java in mind, that is fine. But the way monitor-aware events currently working is rather awkward.