Jonathing comments

Results 178 comments of


                                            Jonathing

[1.21.5] Add item model/item renderer related events

Also I realized that several times while reviewing this, I mistakenly thought this was for 1.21.4. Can you prefix [1.21.5] to the beginning of your PR title? Thanks 😎👍

[1.21.5] Add item model/item renderer related events

Please change the target branch to 1.21.8.

[1.21.5] Add ForgeLayeredDraw & ModifyOverlayLayersEvent as API to making gui layers.

Unable to request reviews on GitHub mobile currently. So: - @Jonathing - @bas - @LexManos

[1.21.4] Add event for adding framepasses

This doesn't compile.

[1.21.4] Add event for adding framepasses

After thinking about it for a little, I realize that it might be desirable to add duplicate frame passes that are differently ordered. Although, I don't know if there is...

[1.21.4] Add event for adding framepasses

> and maintaining it would be even worse if rendering ever gets touched again. Well do I have news for you 💀💀💀💀💀💀

[1.21.4] Add event for adding framepasses

For all intents and purposes, I don't know if this PR will work on 1.21.5 right now given a lot of the intense refactoring changes. Please change the base branch...

[1.15.2-1.14.4] [Feature Request] Add separate-perspective model loader

As Lex mentioned on Discord, a backport is porting a feature or fix to older version of Forge. If you have questions about how we operate, please ask them in...

[1.16.5] FluidUtil.tryEmptyContainer causes fluid dupe

Your description is hard to follow. Could you send a code snippet of what the issue is?

[1.16.5] FluidUtil.tryEmptyContainer causes fluid dupe

Ah, I see. Yeah, we can look at that. My only concern is mods that expect this broken behavior.