Johannes Lorenz

Will merge in 7 days if there are no complaints.

Thanks for offering help. > however when I tested master on Windows and from my testing the terminal support is either broken or not obvious how to get something usable...

> @JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view. My PR does not touch effects at...

~~Open issue: TripleOsc can be resized in this PR. This should not be possible. I have to find out why.~~ Fixed!

> Syncing subwindow and embed's sizes seems rather redundant. From my testing just setting `QLayout::setFixedSize` on embed and moving restrictions from subwindow to embed is enough. Imagine a window has...

This issue remains open because the temporary fix does not make the code future proof.

While still doing a review, I wonder if the `SampleFrame` redesign can go into a separate PR? However, then would we have 2 PRs based on another (alternatively, simply squashing...

One note about the class renaming: `AudioPlugin` still seems a bit confusing, it's more like `AudioPluginWithPinConnector`. Though, the last name is really long, and we might just say "For us,...

Info: Reviewed until here ([b2b8b3b](https://github.com/LMMS/lmms/pull/7459/commits/b2b8b3b67f1e38d60884eefa510b8a082c011d58)). No further comments. If all comments are solved, I will recommend intensive testing and will try to rebase #7387 on this as a verification measure.

@sakertooth Do you mind checking [this comment](https://github.com/messmerd/lmms/pull/3#discussion_r1947934996) about renaming of the classes and giving your opinion? Thanks on advance.