Johannes Lorenz

Results 305 comments of Johannes Lorenz

While this looks sane (to me), it will break previous sound, i.e. will make sounds/projects sound differently now?

Build errors with the sync source? Aside from that, PR OK from my side from a code perspective (not tested).

What is the application of this? I assume this is only used by the Zest-GUI (if yes, which branch)? Or is it used somewhere else?

> Well, fiddlesticks. -Werror is flagging SyncSource in master https://github.com/zynaddsubfx/zynaddsubfx/actions/runs/16579281038/job/46891234678#step:12:652 Would it be possible to combine this with the PR that actually uses that field? If not, we might accept...

This, again, should be merged into #5990, right?

> This Pull request adds sample exporting to lmms that is independent from AudioEngine. A few questions about the scope: 1. Is sample exporting already possible with AudioEngine? 2. About...

I tested the PR and it works and the code is correct. > but there are no instruments that are or can be resized to larger than 250px that are...

You changed all TABs to spaces, can you please fix? Also, what about the unique_ptr question?

@842Mono please reply, or we will close this issue soon.

The code is fine, except for trailing whitespace (at least, the test seems to fail). Can you please fix this? Meanwhile, I can start testing...