Johannes Lorenz

Closing as missing feedback. Feel free to reopen.

I found a very large savefile from 2013, i.e. before toby's commit, which has stuff like this in the MMP: ``` ``` Both the date and your code (because my...

> @JohannesLorenz, can you please provide the test file? Sorry, @michaelgregorius , I forgot! Will do soon .

@michaelgregorius Sorry again. The warning indeed comes at the correct moments. I tested this with 10 files, in all cases, it was right. I just confused some filenames when I...

Houston, we have a problem! :smile: As @cyberrumor reported, if you click an XPF in the presets where the instrument has a LADSPA effect in the FX tab, the check...

Here is the complete list of affected files: ``` $ find data/presets/ -type f -iname "*.xpf" -exec grep -H 'ladspacontrols.*port' '{}' \; | cut -d: -f1 | sort -u data/presets/AudioFileProcessor/Erazor.xpf...

Good point @michaelgregorius , my regex was wrong: `port[^s]` instead of `port` (and the zyn presets cannot be affected - XIZ and XMZ are zyn specific file endings, they cannot...

Two general thoughts about this: 1. Someone recently said they like that we use containers in the CI because it makes it easier for them to just pull the container...

Here are the functions: https://github.com/LMMS/lmms/blob/a9e3e70ae3d28e7aa846904edae71863a9734a71/include/lmms_math.h#L197-L208 https://github.com/LMMS/lmms/blob/a9e3e70ae3d28e7aa846904edae71863a9734a71/include/lmms_math.h#L212-L225

`static` in a header function does make no sense