lmms icon indicating copy to clipboard operation
lmms copied to clipboard

Published 20 hours ago • verified publisher icon LMMS

Fix resize issues

Open JohannesLorenz opened this issue 1 year ago • 1 comments

This is a split-of from lv2-ui which consists of many things I had to do to display Lv2 effects properly (and possibly fix other bugs).

I am still not finished with checking which of the changes do what, and which are unnecessary.

This is already uploaded for documentational purposes.

JohannesLorenz avatar Sep 29 '24 12:09 JohannesLorenz

@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view.

Rossmaxx avatar Oct 03 '24 14:10 Rossmaxx

@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view.

My PR does not touch effects at all. So what you say may be true (in a trivial way), but does not make my PR wrong or unnecessary.

JohannesLorenz avatar Nov 20 '24 22:11 JohannesLorenz

~~Open issue: TripleOsc can be resized in this PR. This should not be possible. I have to find out why.~~ Fixed!

JohannesLorenz avatar Nov 23 '24 13:11 JohannesLorenz

This fixes https://github.com/LMMS/lmms/issues/7510 for me. I haven't tested it extensively and I only reproduced it on a few plugins (caps) but it looks like it's fixed here.

zonkmachine avatar Dec 29 '24 02:12 zonkmachine

Syncing subwindow and embed's sizes seems rather redundant. From my testing just setting QLayout::setFixedSize on embed and moving restrictions from subwindow to embed is enough.

I did basically this in #3532, you could as well test how it works.

sqrvrt avatar Feb 11 '25 18:02 sqrvrt

Syncing subwindow and embed's sizes seems rather redundant. From my testing just setting QLayout::setFixedSize on embed and moving restrictions from subwindow to embed is enough.

Imagine a window has a variable width, and the height has a minimum and maximum value. Can you still model such a case?

I did basically this in #3532, you could as well test how it works.

I will close this PR because I think this should be handled in #3532 - that PR likely has more useful test scenarios.

Aside from his, please keep in mind: Since you started to fix an issue in #3532, namely #7510, you should better first have checked that issue for if anyone is working on it - I referenced my PR there in September 2024. Checking issues that we solve can help prevent that two devs work on the same issue.

JohannesLorenz avatar Feb 16 '25 01:02 JohannesLorenz