Johannes Lorenz

Results 261 comments of Johannes Lorenz

> The above patch Which do you mean? The one that you provided, or the PR that I linked you? Have you tested whether the linked PR fixes the issue?

@yurivict I made a few tests to remove the `-module` parameter, as suggested. I cannot see a difference. I guess the people who wrote the patch know what they are...

@yurivict I removed the `-module` on branch `github-actions`, as a first step. For the `.if ${CHOSEN_COMPILER_TYPE} == gcc` thing, can you please provide a patch, because I do not know...

@yurivict Friendly Reminder: I could still need your feedback here. It will be valuable to create the next calf release.

@yurivict Are you still planning to answer here? I think it would be very important.

> @JohannesLorenz > > In the FreeBSD port audio/calf-lv2 we have this post-install script that makes the absolute symlink relative: > > ``` > post-install: # fix absolute symbolic link...

@yurivict Sorry, I just thought about it again. The links are still absolute. I will change them to relative and let you know then.

I made some tests. If I run `./configure --prefix=$PWD/install` (absolute prefix), then the links are also absolute: ``` calf.so -> /home/.../calf/install/lib/calf/libcalf.so calflv2gui.so -> /home/.../calf/install/lib/calf/libcalflv2gui.so ``` If I run `./configure --prefix=install`,...

> **Summary:** > > 1. I cannot reproduce how to get relative symlinks - can you reproduce it @yurivict ? If yes, how? > > 2. It would be nice...

@yurivict Last reminder: If you don't answer, I will just bring my commit to master without your feedback and make a release next week.