Johannes Lorenz

Results 261 comments of Johannes Lorenz

> I'm testing this and it's working fine so far apart from one issue. It seem like of the mda plugins, the piano and epiano modules do answer to the...

> lv2 units now resets to default values on export. Tested with mda-lv2 and dpf-plugins-lv2. Sorry, what did you mean by "units"? (I'm really dumb, asking 3 months later... :smiling_face_with_tear:)

> I also get occasional crashes. Any idea how I can reproduce those?

> And is there any benefit to nesting it like `lmms::core` or `lmms::gui`? Yes. If you want to use the Mixer in GUI code, in one case, you use `LmmsCore::Mixer`,...

At least, it makes it harder to use `gui` elements in the core now (and easier to find those later). If we really think it is necessary to have a...

> Regarding this question, I would generally advise against nesting namespaces too much, so I'd argue for the `lmms::3osc` schema here, with either `lmms::3osc::gui` or `lmms::gui::3osc` to pair. I thought...

> Should the model classes live in the namespace `lmms::gui` too? In theory, there could be a different GUI accessing the same models (in practice, very unlikely?). If we introduce...

@irrenhaus3 Is anything blocking you with this? It's a useful PR and is theoretically on the re-org list (though we agreed we can skip it).

Btw, this is just the issue. The real PR is actually here: #6174 .

About the whole discussion of `MixerWorkerThread` -> `lmms::mixer::WorkerThread`: I think this is really easily done with a simple shell/python script. Pseudo code: ``` For all classes c in LMMS: if...